-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate FlowGroupEntry.with_directives #696
Conversation
Also deprecates FlowGroupEntry.with_directives.
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
@@ -1703,7 +1703,9 @@ class A(FlowProject): | |||
def foo_operation(job): | |||
pass | |||
|
|||
@pytest.mark.filterwarnings("ignore:*with_directives*:FutureWarning") | |||
@pytest.mark.filterwarnings( | |||
"ignore:.*with_directives has been deprecated.*:FutureWarning" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b-butler The message is a regex, not a glob. Previously it started with *
, which means "repeat previous character". This caused pytest to crash because no previous character was defined for a string starting with *
.
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
- Coverage 80.27% 80.27% -0.01%
==========================================
Files 30 30
Lines 3143 3153 +10
Branches 767 770 +3
==========================================
+ Hits 2523 2531 +8
- Misses 485 486 +1
- Partials 135 136 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@csadorf I'd like to let you approve this before merging since you requested changes. I think it's ready to go once you approve. |
Description
Adds a
directives
keyword-only argument toFlowGroupEntry.__call__
.Motivation and Context
Mimics the changes to
FlowGroup.operation
.Checklist: